Support PDF/image submissions in get_submission_files - #69
Open
cyrus- wants to merge 1 commit into
Open
Conversation
get_submission_files only read the `text_files` key and raised
NotImplementedError("Image only submissions not yet supported") for any
submission without autograder text files — i.e. ordinary PDF/image
submissions, which is the common case for written assignments.
Also request `pdf_attachment` and `image_attachments` and fall back to them:
Gradescope stores the student's original upload as a combined `pdf_attachment`
(and individual `image_attachments` when there is no combined PDF). Initialize
`aws_links` so a non-200 response no longer raises UnboundLocalError.
Adds credential-free unit tests covering text_files, pdf_attachment,
image_attachments, and the empty case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_submission_files only read the
text_fileskey and raised NotImplementedError("Image only submissions not yet supported") for any submission without autograder text files — i.e. ordinary PDF/image submissions, which is the common case for written assignments.Also request
pdf_attachmentandimage_attachmentsand fall back to them: Gradescope stores the student's original upload as a combinedpdf_attachment(and individualimage_attachmentswhen there is no combined PDF). Initializeaws_linksso a non-200 response no longer raises UnboundLocalError.Adds credential-free unit tests covering text_files, pdf_attachment, image_attachments, and the empty case.