Skip to content

feat: Ultralytics Integration#20

Open
joydeep049 wants to merge 3 commits into
nyunAI:mainfrom
joydeep049:ultralytics-integration
Open

feat: Ultralytics Integration#20
joydeep049 wants to merge 3 commits into
nyunAI:mainfrom
joydeep049:ultralytics-integration

Conversation

@joydeep049

Copy link
Copy Markdown

Added basic structure for Integration of Ultralytics into Nyuntam Vision.

-> Flake8 check passed
-> Black check passed
-> Interrogate check passed (100% coverage)
-> PyUpgrade check passed

cc @Arnav0400 @Akash-guna

Signed-off-by: joydeep049 <bntripathy123@gmail.com>
@Akash-guna

Copy link
Copy Markdown
Contributor

The solution does not include include loading custom weights. YOLO("{custom_model_path}") should allow loading custom weights other than stock pretrained weights.

@joydeep049

joydeep049 commented Nov 3, 2024

Copy link
Copy Markdown
Author

Just wanted to confirm my understanding:
We either directly load a yolo model like yolo11n.pt or we load custom weights from a cfg file. Is that correct?

@Akash-guna

@joydeep049

Copy link
Copy Markdown
Author

Comment thread core/models/__init__.py Outdated
@Akash-guna
Akash-guna requested a review from Arnav0400 November 11, 2024 17:02
@Arnav0400

Copy link
Copy Markdown
Contributor

@joydeep049 which models did you test the script on, also are there any experimental numbers?

@joydeep049

joydeep049 commented Nov 13, 2024

Copy link
Copy Markdown
Author

I've been trying to test ultralytics with resnet with distill, but I'm not able to access the nyun docs.
The nyun docs link gives a 404 error
@Arnav0400

@joydeep049 joydeep049 closed this Nov 13, 2024
@joydeep049 joydeep049 reopened this Nov 13, 2024
@joydeep049

Copy link
Copy Markdown
Author

(Accidentally clicked on close PR)

@Arnav0400

Copy link
Copy Markdown
Contributor

https://nyunai.github.io/nyuntam-docs/ - Here are the docs

@joydeep049

joydeep049 commented Nov 17, 2024

Copy link
Copy Markdown
Author

Screenshot 2024-11-17 134321

Do I need some kind of access to use nyun-vision and nyun-adapt?

@Arnav0400

@Arnav0400

Arnav0400 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

We recommend using virtual environments instead of dockers for dev cycles - https://github.com/nyunAI/nyuntam?tab=readme-ov-file#git--virtual-environment

Additionally if you want to use dockers, we have fixed the permissions and you can pull now.

@joydeep049

joydeep049 commented Nov 19, 2024

Copy link
Copy Markdown
Author

I'm testing ultralytics on the coco dataset using prune strategy and will share the results soon.
Meanwhile, I wanted to let you know that there are some issues which I had to take care of before I could run my config.

  1. In nyuntam-vision/factory.py, in the get_algorithm method the initialize_initialization function is given two arguments, but in the original definition in nyuntam-vision/prune/__init__.py it takes only one argument.

  2. Line 57 of nyuntam-vision/factory.py is kw.update(kwargs[algo_type][algorithm]), but in the config we use two prune blocks which is wrong.

  3. In the create_from_dict() method in nyuntam/factory.py, the caller iterating over cls always throws an error. But if we do something like:

cls = get_factories(task, job_service)
if(cls[0]):
    return cls[0](args)
else:    
    raise Exception("Factory instance could not be created.")

This can be done because cls only has a single element. Also, it works locallly.

Should I put separate PRs for these issues?

@Arnav0400

@Arnav0400

Copy link
Copy Markdown
Contributor

Thanks @joydeep049, since nyuntam is a relatively new toolkit we expect many such bugs and errors. @Abhrant is actively looking to resolve them and I would really appreciate if you can raise issues and the corresponding PRs for them.

@joydeep049

Copy link
Copy Markdown
Author

Sure! I will do the aforementioned.

Meanwhile, I request you to take a look at my LinkedIn messages.

@Arnav0400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants