Skip to content
This repository was archived by the owner on Dec 4, 2025. It is now read-only.

Trying to fix Portal UI Bug#754

Merged
tdanielles merged 4 commits into
devfrom
trisha/fix-portal-ui
Nov 15, 2025
Merged

Trying to fix Portal UI Bug#754
tdanielles merged 4 commits into
devfrom
trisha/fix-portal-ui

Conversation

@tdanielles
Copy link
Copy Markdown
Contributor

@tdanielles tdanielles commented Nov 15, 2025

Description

  • Increase z-index for toggle button so it is visible
  • Fix logic for showing toggle button so that it now properly shows, expands, and de-expands
Screen Shot 2025-11-15 at 2 26 55 PM

Notes

  • I think it was not showing before because we were using the svg as a bg image in the css -> changed it to add src directly in
  • Something was wrong in the overflow calculation logic before that didn't catch other components where there should've been a toggle button

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 15, 2025

Visit the preview URL for this PR (updated for commit b2a1ef9):

https://nwplus-ubc--pr754-trisha-fix-portal-ui-oeg0tce6.web.app

(expires Sat, 22 Nov 2025 22:25:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

@tdanielles tdanielles marked this pull request as ready for review November 15, 2025 22:27
@tdanielles tdanielles merged commit f243855 into dev Nov 15, 2025
2 checks passed
@tdanielles tdanielles deleted the trisha/fix-portal-ui branch November 15, 2025 22:29
tdanielles added a commit that referenced this pull request Nov 15, 2025
* update charity submission blurb to dynamically pull hackathon name

* [HC2025] update charities (#745)

* update charity submission blurb to dynamically pull hackathon name

* update charities for hackcamp 2025

* fix notion link to public version

* [HC 2025] Add superlative prize submission  (#746)

* update charity submission blurb to dynamically pull hackathon name

* add superlative prize submission (hacker view)

* add superlative prize submission (admin view)

* Fix bug on projects not showing up under superlative prizes (#750)

* fix projects on prizes not showing up

* Also add grades to csv download on overall table

* Add Figma submission link (#748)

* initial commit

* revise

* Update peer judging rubric to link to HC2025's (#749)

* initial commit

* surface figma link

* fix peer judging project link (#753)

* Trying to fix Portal UI Bug (#754)

* remove pts

* toggle bug?

* copilot clutch

* hopefully fix svg not showing

---------

Co-authored-by: ErpingS <erpingsun@gmail.com>
Co-authored-by: Erping <111095333+ErpingS@users.noreply.github.com>
ErpingS added a commit that referenced this pull request Nov 18, 2025
* update charity submission blurb to dynamically pull hackathon name

* [HC2025] update charities (#745)

* update charity submission blurb to dynamically pull hackathon name

* update charities for hackcamp 2025

* fix notion link to public version

* [HC 2025] Add superlative prize submission  (#746)

* update charity submission blurb to dynamically pull hackathon name

* add superlative prize submission (hacker view)

* add superlative prize submission (admin view)

* Fix bug on projects not showing up under superlative prizes (#750)

* fix projects on prizes not showing up

* Also add grades to csv download on overall table

* Add Figma submission link (#748)

* initial commit

* revise

* Update peer judging rubric to link to HC2025's (#749)

* initial commit

* surface figma link

* fix peer judging project link (#753)

* Trying to fix Portal UI Bug (#754)

* remove pts

* toggle bug?

* copilot clutch

* hopefully fix svg not showing

* fix peer judging project link (#756)

* fix peer judging project link

* fix project link view in admin judging

---------

Co-authored-by: trisha <82386753+tdanielles@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants