[WIP] Events: Add Chat#1090
Draft
plenarius wants to merge 11 commits into
Draft
Conversation
…ore informative in deprecation notes
plenarius
marked this pull request as draft
October 30, 2020 17:46
Move SendMessage into Creature Move Get|SetChatHearingDistance into Player Add shims in nwnx_chat for all functionality Warn of deprecation on Chat constructor and in all functions Add chat hearing distance test unit to nwnx_player_t
plenarius
marked this pull request as ready for review
November 2, 2020 23:18
Collaborator
Author
|
Closes #791 with latest update |
plenarius
marked this pull request as draft
November 4, 2020 20:17
Collaborator
Author
|
Tabling this as I reflect on some hurdles with module chat script and core nwn chat functionality. This may just have to be a breaking change but I'd like to come up with a document for migration if that's the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #746
I'm not really sure how to best create a deprecation shim so for now it's just a bunch of notices
Note: I also added/(fixed?) targeted messages now being able to be sent on party and dm channel.