fix(types): broken nuxt v4 check#300
Merged
Merged
Conversation
…ation The previous gate relied on `future.compatibilityVersion === 4`, which is unset on most Nuxt 4 projects, so the `nitropack/types` augmentation never ran and `routeRules.robots` failed type-checking with TS2353.
harlan-zw
force-pushed
the
fix/299-nitropack-types-nuxt4-detection
branch
from
2f397f3 to
fe0f79a
Compare
commit: |
harlan-zw
changed the title
Covers the user-facing TS2353 scenario from #299. Existing tests assert augmentation on `nitropack/types` directly; this asserts the full chain through `NuxtConfig['routeRules']` that breaks in user configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #299
❓ Type of change
📚 Description
The
nitropack/typesaugmentation added in #295 was gated onnuxt.options.future.compatibilityVersion === 4, which is unset on most Nuxt 4 projects. The check therefore silently skipped the second augmentation, leavingrouteRules.robotsfailing typecheck with TS2353 on Nuxt 4.Switched the gate to
@nuxt/kit'sisNuxtMajorVersion(4, nuxt), which reads the actual installed Nuxt version. Existing cross-module-path regression tests intest/types/templates.test-d.tscover the fix.