CI: run the H.264 video_sender E2E on Windows too#48
Merged
Conversation
The Windows E2E job filtered video_sender to `vp8 video frames`, leaving the H.264 variant Linux-only. video_sender is a unidirectional harness (Dart sends, the browser only decodes — no bidirectional ICE), so it isn't affected by the cross-interface DTLS-direction flakiness that keeps the webdartc-as-offerer scenarios off Windows. Verified locally: the H.264 variant passes 10/10 on Windows (OpenH264 is bundled and Chrome for Testing ships an H.264 decoder). Broaden the selector to `video frames` so it matches both the vp8 and h264 video_sender tests, and correct the stale comment that lumped this H.264 sender in with the flaky bidirectional scenarios. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
video_sender_testtovp8 video frames, leaving the H.264 variant Linux-only.video_senderis a unidirectional harness (Dart sends, the browser only decodes — no bidirectional ICE), so it is not affected by the cross-interface DTLS-direction flakiness that keeps the webdartc-as-offerer scenarios (1/2/3, packet-loss) off Windows.vp8 video frames→video framesso it matches both the VP8 and H.264video_sendertests, and correct the stale comment that lumped this H.264 sender in with the flaky bidirectional scenarios.Why it's safe on Windows
video_sendervariant passes 10/10.connected, then cross-interface UDP sends fail with errno 1214/1231 and the DTLS direction is dropped). Those need a transport-layer fix, tracked separately.Test plan
dart test test/e2e/video_sender_test.dart -n "h264 video frames"×10 on Windows — 10/10 pass.vp8andh264video_sender and stays green.🤖 Generated with Claude Code