Fix the issue that edit command allows duplicate emails or phone#342
Closed
Elinengu wants to merge 490 commits into
Closed
Fix the issue that edit command allows duplicate emails or phone#342Elinengu wants to merge 490 commits into
Elinengu wants to merge 490 commits into
Conversation
Update UG repetition syntax
Handle duplicate module codes
Update UG add command (new `r/` parameter)
Fix findcommand syntax in UG
Find command now support finding contacts based on module-role with prefix r/, e.g. find r/cs1101s-ta. If role is not specified, student is assumed. When multiple inputs are given, e.g. find r/cs1101s-ta r/cs1231s n/Ben, contacts matching any of the keywords given will be shown.
find n/name r/module-role only finds matching module-role. Refine the logic such that find n/name r/module-role finds contacts with matching name AND module-role.
…-msg Fix inconsistent command format
Use the following syntax: `edit [index] /r+(MODULECODE[-ROLETYPE])+`
…nal-in-add-command Make module optional in add command
…isplayed-email Bugfix: `Optional[]` no longer displayed in edit messages
…ield Add a new field: description
Add the state list
…d-gui Add icons for person info in Person Card
# Conflicts: # src/test/java/seedu/address/logic/parser/ParserUtilTest.java
…-role `edit r/-` now deletes irrespective of role if role is unspecified
Chained search
potaotototo
pushed a commit
to potaotototo/tp
that referenced
this pull request
Nov 11, 2024
…isplay-message Change Person to Student in display message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154
The reason why the original if else statement does not work is that, as the the
isSamePersoncheck if there is the same email or same phone number, hence in this statement:The duplicate email/phone number can by pass the
hasPersoncheck if the original phone number or email remains unchanged.