Skip to content

Validate KB and backup bucket exist before a restore#3800

Merged
jotare merged 3 commits into
mainfrom
fix-restore-for-unexisting-kb
Jul 10, 2026
Merged

Validate KB and backup bucket exist before a restore#3800
jotare merged 3 commits into
mainfrom
fix-restore-for-unexisting-kb

Conversation

@jotare

@jotare jotare commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested review from a team as code owners July 10, 2026 09:55
Comment thread nucliadb/src/nucliadb/backups/restore.py Outdated
Comment thread nucliadb/src/nucliadb/backups/restore.py Outdated
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.48%. Comparing base (cfe1311) to head (79541ff).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3800      +/-   ##
==========================================
+ Coverage   85.38%   85.48%   +0.10%     
==========================================
  Files         571      571              
  Lines       50466    50451      -15     
  Branches    15318    15293      -25     
==========================================
+ Hits        43090    43129      +39     
+ Misses       6746     6690      -56     
- Partials      630      632       +2     
Flag Coverage Δ
nidx 80.97% <ø> (-0.03%) ⬇️
nucliadb 74.07% <100.00%> (+0.22%) ⬆️
nucliadb-ingest 43.87% <30.00%> (+0.01%) ⬆️
nucliadb-reader 43.69% <30.00%> (-0.03%) ⬇️
nucliadb-search 54.83% <30.00%> (-0.01%) ⬇️
nucliadb-standalone 46.03% <30.00%> (-0.01%) ⬇️
nucliadb-train 44.68% <30.00%> (-0.01%) ⬇️
nucliadb-writer 47.22% <30.00%> (+0.01%) ⬆️
nucliadb_dataset 73.40% <ø> (ø)
nucliadb_models 69.72% <ø> (ø)
nucliadb_sdk 82.28% <ø> (ø)
nucliadb_telemetry 85.67% <ø> (ø)
nucliadb_utils 80.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotare jotare force-pushed the fix-restore-for-unexisting-kb branch from 50c6f3e to f0ca25b Compare July 10, 2026 10:04
@jotare jotare force-pushed the fix-restore-for-unexisting-kb branch from f0ca25b to 26cdfd7 Compare July 10, 2026 10:05
Comment thread nucliadb/src/nucliadb/backups/restore.py Outdated
lferran
lferran previously approved these changes Jul 10, 2026
@jotare jotare force-pushed the fix-restore-for-unexisting-kb branch from 80f1d2b to 75d6b79 Compare July 10, 2026 11:40
@jotare jotare merged commit e05d915 into main Jul 10, 2026
41 checks passed
@jotare jotare deleted the fix-restore-for-unexisting-kb branch July 10, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants