Skip to content

test resource ask endpoint #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunbit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test resource ask endpoint #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions nuclia_e2e/nuclia_e2e/tests/test_kb_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,22 @@ async def security_groups_test_ask(
security=RequestSecurity(groups=security_groups) if security_groups is not None else None,
),
)

async def security_groups_test_resource_ask(
client: AsyncNucliaDBClient, question: str, security_groups: list[str] | None
) -> AskAnswer:
kb = AsyncNucliaKB()
return await kb.search.ask(
ndb=client,
query=AskRequest(
query=question,
reranker=RerankerName.PREDICT_RERANKER,
rephrase=False,
generative_model="chatgpt-azure-4o-mini",
features=[ChatOptions.SEMANTIC],
security=RequestSecurity(groups=security_groups) if security_groups is not None else None,
),
)

# There are two resources describing to recipes
# - omelette groups = apprentices, chefs
Expand All @@ -59,6 +75,9 @@ async def security_groups_test_ask(
secured_question = "What do you need to make a roasted chicken?"
answer = await security_groups_test_ask(async_ndb, secured_question, security_groups=None)
assert answer.status == "success"
from pprint import pprint
pprint(answer)
pprint(answer.object)

# Temporal SA key with no explicit security, should allow the question
# Recreating the key and client each time, as it has a 10 seconds ttl
Expand All @@ -79,3 +98,13 @@ async def security_groups_test_ask(
async_ndb_sa_temp = get_async_kb_ndb_client(zone, kbid, service_account_token=new_sa_temp_key)
answer = await security_groups_test_ask(async_ndb_sa_temp, secured_question, security_groups=None)
assert answer.status == "no_context"

# # Temporal SA key with key security (injected via authorizer), should allow the question
# # Recreating the key and client each time, as it has a 10 seconds ttl
# new_sa_temp_key = await regional_api.create_service_account_temp_key(
# new_sa_key, security_groups=["apprentices"]
# )
# async_ndb_sa_temp = get_async_kb_ndb_client(zone, kbid, service_account_token=new_sa_temp_key)
# answer = await security_groups_test_resource_ask(async_ndb_sa_temp, secured_question, security_groups=None)
# assert answer.status == "no_context"

Loading