Skip to content

Remove redundant paragonie/random_compat dependency#802

Merged
core23 merged 1 commit into
nucleos:4.1.xfrom
brendt:compat/remove-paragonie-random_compat
Apr 7, 2026
Merged

Remove redundant paragonie/random_compat dependency#802
core23 merged 1 commit into
nucleos:4.1.xfrom
brendt:compat/remove-paragonie-random_compat

Conversation

@brendt

@brendt brendt commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

This package depends on paragonie/random_compat: ^1 || ^2 || ^9, but also php: ^8.3. Since random_bytes and random_int were added in PHP 7.0, the dependency on paragonie/random_compat seems redundant?

@core23 core23 added this to the 4.1.0 milestone Apr 4, 2026
@core23

core23 commented Apr 4, 2026

Copy link
Copy Markdown
Member

Just fixed the main branch. Can you please rebase @brendt ?

@brendt brendt force-pushed the compat/remove-paragonie-random_compat branch from 38ee6a7 to 6e14f6b Compare April 7, 2026 07:24
@brendt

brendt commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Done :)

@core23 core23 merged commit 083c4b2 into nucleos:4.1.x Apr 7, 2026
16 checks passed
@core23

core23 commented Apr 7, 2026

Copy link
Copy Markdown
Member

Thanks :)

@brendt brendt deleted the compat/remove-paragonie-random_compat branch April 9, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants