Skip to content

Add macos workflow compatibility#82

Merged
jwaiton merged 9 commits into
nu-ZOO:mainfrom
Ian0sborne:add-macos-workflow-compatibility
May 27, 2026
Merged

Add macos workflow compatibility#82
jwaiton merged 9 commits into
nu-ZOO:mainfrom
Ian0sborne:add-macos-workflow-compatibility

Conversation

@Ian0sborne
Copy link
Copy Markdown
Contributor

@Ian0sborne Ian0sborne commented Apr 29, 2026

This PR builds on #56 and implements the final changes needed to ensure that GitHub workflow test suites are able to catch non-functionality with MacOS systems before PRs are merged.

@Ian0sborne Ian0sborne requested a review from a team April 29, 2026 10:02
@Ian0sborne Ian0sborne force-pushed the add-macos-workflow-compatibility branch from f891bf0 to c7d4e99 Compare April 29, 2026 10:16
@Ian0sborne
Copy link
Copy Markdown
Contributor Author

Ian0sborne commented Apr 29, 2026

Apparently conda env create does not accept a python= argument (this only works on conda env). The -f fetches the Python version inside the YAML file, which already declares python = 3.12 under dependencies. Therefore the version is already handled correctly without the extra argument.

@Ian0sborne Ian0sborne force-pushed the add-macos-workflow-compatibility branch from e85a791 to 2784ab1 Compare April 30, 2026 11:01
@Ian0sborne Ian0sborne requested review from MattZur and jwaiton April 30, 2026 11:07
jwaiton
jwaiton requested changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jwaiton jwaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some small tweaks.

Comment thread .github/workflows/testsuite.yml

PYTEST_ADDOPTS=--color=yes HYPOTHESIS_PROFILE=travis-ci python -m pytest -v
PYTEST_ADDOPTS=--color=yes HYPOTHESIS_PROFILE=travis-ci \
conda run -n MULE-3.12-10-24 python -m pytest -v
Copy link
Copy Markdown
Member

@jwaiton jwaiton May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoding the conda environment here scares me, although Im unsure of a better alternative at the moment.

Comment thread setup.sh
jwaiton
jwaiton approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jwaiton jwaiton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces testing for MacOS and a working conda installation for MacOS with MULE! Great work.

I have a feeling like it wont work perfectly, and we'll have machine dependent issues, but we'll see :)

All thats left is a rebase, and it will be ready to merge.

@Ian0sborne Ian0sborne force-pushed the add-macos-workflow-compatibility branch from 2784ab1 to ec67432 Compare May 27, 2026 13:06
@jwaiton jwaiton merged commit 9a5c2ea into nu-ZOO:main May 27, 2026
3 checks passed
@jwaiton jwaiton mentioned this pull request May 27, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwaiton jwaiton jwaiton approved these changes

@MattZur MattZur Awaiting requested review from MattZur

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ian0sborne @jwaiton @RusilKoirala