Polish std/net release boundary#127
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR polishes the
Confidence Score: 5/5This looks safe to merge.
Reviews (4): Last reviewed commit: "test: harden std/net review follow-ups" | Re-trigger Greptile |
Contributor
Author
|
Addressed the Greptile findings in
Verification run locally: cargo fmt
cargo build --profile dev-release
./target/dev-release/ntnt docs --generate
cargo test --lib stdlib::net -- --nocapture
cargo test --test std_net_tests -- --nocapture
cargo test
greptile review --agentLocal Greptile result after fixes: safe to merge, confidence 4/5, no review comments. The remaining note is the explicit release tradeoff that multi-port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net/policy.rsand keep private probing gated only byNTNT_NET_ALLOW_PRIVATE=1plus per-callallow_privatestd/netVerification
cargo fmt && git diff --check && cargo test --lib stdlib::net -- --test-threads=1cargo build --profile dev-releasecargo test --test type_checker_tests std_net -- --nocapture./target/dev-release/ntnt docs --generate./target/dev-release/ntnt validate examples/(passes; existing examples/collections_demo warnings only)./target/dev-release/ntnt lint examples/(passes; existing warnings/suggestions only)cargo test