Skip to content

add EMProps class to IEvanMiya strategy#18

Merged
ntbloom merged 2 commits into
mainfrom
make-evanmiya-props
Mar 28, 2023
Merged

add EMProps class to IEvanMiya strategy#18
ntbloom merged 2 commits into
mainfrom
make-evanmiya-props

Conversation

@ntbloom

@ntbloom ntbloom commented Mar 22, 2023

Copy link
Copy Markdown
Owner

No description provided.

@ntbloom ntbloom requested a review from seth127 March 22, 2023 02:05
@ntbloom

ntbloom commented Mar 22, 2023

Copy link
Copy Markdown
Owner Author

@seth127 this MR brings in stronger typing around properties gathered from external data sources. This should also make things easier for editor autocomplete, etc. I went ahead and updated the existing strategies but all the outputs should be unchanged.

@seth127

seth127 commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Cool, I'll take a look at some point. Glad to see you're back at this tonight. I spent the evening on #19.

Also, this may or may have an impact on the changes in #15. I'll look at that too.

@ntbloom

ntbloom commented Mar 23, 2023

Copy link
Copy Markdown
Owner Author

I can probably fix #15 if we get this merged. @michaelmcd18

@ntbloom ntbloom merged commit fbd05ce into main Mar 28, 2023
@ntbloom ntbloom deleted the make-evanmiya-props branch March 28, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants