Skip to content

Auto close results#16

Open
elucid wants to merge 2 commits into
nschum:masterfrom
elucid:auto-close-results
Open

Auto close results#16
elucid wants to merge 2 commits into
nschum:masterfrom
elucid:auto-close-results

Conversation

@elucid

@elucid elucid commented Apr 11, 2012

Copy link
Copy Markdown

I've modified full ack to:

  • automatically close the results window when there are no results
  • close the results window after browsing to a result using ack-find-match

I find it a little annoying to have an empty results window left open when the minibuffer will tell me there were 0 results. Also I seldom want to look at alternative results after browsing to the one I want.

I don't know if either of these are generally desired behaviour. I know that some emacs users prefer to have a fixed window split where all temporary results oriented buffers are displayed and I'm not sure how this would interact with that.

Thoughts?

@nschum

nschum commented Apr 12, 2012

Copy link
Copy Markdown
Owner

If the user has multiple windows open, this will indeed mess with his/her existing windows. I don't think that's okay.
Can you modify the patch to only close windows if full-ack has actually created them? (Or maybe you just want to set ack-display-buffer to 'after to not show empty results?)

And I don't think "ack-find-match" should be changed. There should be an additional command "ack-find-match-and-kill-window" that users can remap if they prefer it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants