Auto close results#16
Open
elucid wants to merge 2 commits into
Open
Conversation
note: "Ack finished with 0 matches" will still show in the minibuffer
Owner
|
If the user has multiple windows open, this will indeed mess with his/her existing windows. I don't think that's okay. And I don't think "ack-find-match" should be changed. There should be an additional command "ack-find-match-and-kill-window" that users can remap if they prefer it.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've modified full ack to:
ack-find-matchI find it a little annoying to have an empty results window left open when the minibuffer will tell me there were 0 results. Also I seldom want to look at alternative results after browsing to the one I want.
I don't know if either of these are generally desired behaviour. I know that some emacs users prefer to have a fixed window split where all temporary results oriented buffers are displayed and I'm not sure how this would interact with that.
Thoughts?