Conversation
Owner
Author
|
@aartdem, готово к ревью |
aartdem
reviewed
Apr 21, 2026
| @@ -0,0 +1,40 @@ | |||
| grammar QLang; | |||
|
|
|||
| prog: stmt* EOF ; | |||
There was a problem hiding this comment.
А зачем тут понадобился EOF? В условии не было
Owner
Author
There was a problem hiding this comment.
Добавил коммит без него, все работает. Но для обработки ошибок lexer-а пришлось добавить явно <EOF>?, чтобы строчки из тестов были валидными
aartdem
reviewed
Apr 21, 2026
| stream = CommonTokenStream(lexer) | ||
| parser = QLangParser(stream) | ||
| tree = parser.prog() | ||
| return (tree, parser.getNumberOfSyntaxErrors() == 0) |
There was a problem hiding this comment.
Думаю, тут в результате стоит еще и учитывать возможные ошибки lexer-а
ns-58
force-pushed
the
Task11
branch
4 times, most recently
from
April 21, 2026 13:46
e6ab65f to
4d8ddf1
Compare
aartdem
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Требуемые функции: