build: Upgrade Node baseline to 24

[encoura-shippy-ai]

Summary

• Updates the local DLS Node baseline from v22 to v24.
• Updates PR and CI workflow Node pins from 22 to 24.
• Updates workflow JavaScript actions to current Node-24-capable majors (actions/setup-node@v6, actions/checkout@v6, actions/cache@v5).
• Adds the matrix Node version to Chromatic cache keys so Node 24 jobs do not reuse stale Node 22 node_modules caches.
• Regenerates package-lock.json from a fully cleared install under Node 24/npm 11.
• Keeps two TypeScript lint auto-fixes produced by the regenerated dependency set.

Jira

• https://nrccua.atlassian.net/browse/AP-6282

Validation

• npm i --ignore-scripts after trashing node_modules and package-lock.json under Node v24.16.0 / npm 11.13.0
• npm ls --depth=0 under Node 24, no dependency problems reported
• npm ci --ignore-scripts under Node 24
• npm test under Node 24 after npm i
• npm test under Node 24 after clean npm ci
• npm run test:prettier under Node 24
• git diff --check

CI note

• This replaces the earlier fork-based PR (build: Upgrade Node baseline to 24 #92) so Chromatic can access the repo project token.
• Snyk Code may still report the known Code test limit reached quota error; Snyk license/security checks previously passed.

[joncursi]

Lets also regenerate the package-lock.json file. I think a full nuke and npm i is in order, under the new node/npm version?

[encoura-shippy-ai]

Addressed in cfd36a3.

I did the full lockfile regeneration path under Node v24.16.0 / npm 11.13.0:

• trashed node_modules and package-lock.json
• ran npm i --ignore-scripts
• confirmed package.json did not change
• ran npm ls --depth=0 with no dependency problems
• ran npm ci --ignore-scripts
• ran full npm test after both the npm i install and the clean npm ci install

The regenerated lockfile changed transitive resolutions and dropped the audit output to 4 total vulnerabilities locally. The new dependency graph also caused the repo's lint step to auto-fix two redundant TypeScript assertions; I kept those since they are what npm test produces under the regenerated lockfile and they do not change runtime output.