Skip to content

Use ThreadPoolExecutor instead of Bare Threads#2

Open
rabinadk1 wants to merge 7 commits into
nrasadi:masterfrom
rabinadk1:patch-1
Open

Use ThreadPoolExecutor instead of Bare Threads#2
rabinadk1 wants to merge 7 commits into
nrasadi:masterfrom
rabinadk1:patch-1

Conversation

@rabinadk1

Copy link
Copy Markdown
Contributor
  1. Use ThreadPoolExecutor to make threads automatically join the calling thread
  2. Use it to join hanging threads
  3. Use staticmethod instead of classmethod when the class variable is not used
  4. Use thread lock as a context manager
  5. Remove unused parameter id
  6. Formatted the code using black
  7. Sorted imports with isort
  8. Resolved flake8 errors
  9. Write a definite version in requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant