fix: drop OIDC modules extracted into nova_auth_oidc#11
Merged
Conversation
nova_auth_oidc and nova_auth_oidc_jwt were moved to the dedicated nova_auth_oidc application, but their pre-extraction copies were left here. Shipping both makes any release that depends on nova_auth_oidc fail with duplicate-module errors (relx, and rebar3 dialyzer). Remove the stale copies; the dedicated app is the source of truth.
Taure
added a commit
to Taure/triagebot
that referenced
this pull request
May 27, 2026
Replace every moving branch pin with a tag or commit SHA so the release is reproducible and no dependency can shift under us: - gakudan_liveboard -> tag v0.1.0 (just released) - nova_auth_oidc -> tag v0.1.0 - nova -> SHA (Nova is pre-release; jsonlogger fork) - datastar -> SHA (pre-release) - nova_auth -> fork SHA (drops the extracted OIDC modules; upstream fix tracked in novaframework/nova_auth#11)
Taure
added a commit
to Taure/triagebot
that referenced
this pull request
May 27, 2026
* feat: mount gakudan_liveboard dashboard behind OIDC auth Embed the gakudan_liveboard live console in triagebot, gated by Google OIDC login plus an email-domain allowlist so the dashboard is not public. - bump gakudan v0.1.3 -> v0.1.30; add gakudan_liveboard, datastar, telemetry and nova_auth_oidc deps and app entries - triagebot_oidc_config: nova_auth_oidc provider config from env - triagebot_dashboard_auth: session + domain-allowlist route security (no session -> 302 login, disallowed domain -> 403) - triagebot_auth_controller: adapt binary-keyed bindings to the atom provider key nova_auth_oidc_controller expects - router: public /auth login/callback + self-hosted assets, protected dashboard route group - pin nova_auth to a fork that drops the nova_auth_oidc/_jwt modules it still ships post-extraction (they collide with the dedicated app and break relx + dialyzer) - tests for the auth decision, binding adapter and OIDC config * build: pin all deps to immutable refs Replace every moving branch pin with a tag or commit SHA so the release is reproducible and no dependency can shift under us: - gakudan_liveboard -> tag v0.1.0 (just released) - nova_auth_oidc -> tag v0.1.0 - nova -> SHA (Nova is pre-release; jsonlogger fork) - datastar -> SHA (pre-release) - nova_auth -> fork SHA (drops the extracted OIDC modules; upstream fix tracked in novaframework/nova_auth#11)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nova_auth_oidcandnova_auth_oidc_jwtwere extracted into the dedicatednova_auth_oidcapplication, but their pre-extraction copies were left here. Any release that depends on bothnova_authandnova_auth_oidcthen fails with duplicate-module errors — relx refuses to assemble ("Duplicated modules: nova_auth_oidc, nova_auth_oidc_jwt"), andrebar3 dialyzerhard-fails ("Duplicates of module nova_auth_oidc_jwt").This removes the stale copies; the dedicated app is the source of truth. Nothing inside
nova_authreferences either module.Found while wiring
nova_auth_oidcinto a Nova app (triagebot).