Add RMS renormalization option (fixes magnitude-collapse quality loss)#2
Open
huwhitememes wants to merge 1 commit into
Open
Add RMS renormalization option (fixes magnitude-collapse quality loss)#2huwhitememes wants to merge 1 commit into
huwhitememes wants to merge 1 commit into
Conversation
Adds a non-breaking `renormalize` option that rescales the per-layer-weighted tensor to its input RMS, so tap ratios can be rebalanced without inflating the overall conditioning magnitude. Off by default; existing behavior is unchanged. Background: the global multiplier amplifies the whole tensor, so with the default weights + multiplier=4.0 the magnitude inflates ~8.7x (4x mult x ~2.2x from the per-layer gains) -- matching the community-reported quality collapse (likeness, prompt adherence, colour). With renormalize on, the multiplier becomes the sole magnitude control. Co-Authored-By: Claude <noreply@anthropic.com>
huwhitememes
force-pushed
the
fix/quality-preserving-renormalize
branch
from
0c51575 to
9b5c71d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@/tmp/pr2_body.md