fix: supersede old active program when regenerating via coach#90
Merged
Conversation
When 'Regenerate plan' creates a new program via POST /coach/programs, any previously-active program stays status='active' and its future (non-completed) workouts remain in the database. The calendar query shows ALL PlannedWorkout regardless of program, so old workouts from a superseded generation (e.g. W/Sa from a now-T/Th schedule) continue to appear alongside the new ones. Fix: deactivate old active programs (status='superseded') and drop their future planned workouts before adding the new one, matching the semantics of apply_program's cutover. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Regenerate plan creates a new program via
POST /coach/programs, any previously-active program staysstatus='active'and its future workouts (e.g. W/Sa from an old schedule) remain in the database. The calendar query fetches allPlannedWorkoutregardless of program, so orphan workouts from a superseded generation continue to appear alongside the new ones.Fix: before adding the new program, deactivate all existing active programs (set to
status='superseded') and drop their future (non-completed) workouts — matching the same cutover semantics thatapply_programalready uses for the modify path.Test plan
apply_program's cutover semantics