Plan tab: merge Objectives + Upcoming activities into one Agenda list#84
Merged
Conversation
Both sections were flat lists over data already rendered as markers on the calendar grid (fuchsia band/peak for objectives, sky ring for activities), duplicating spatial info with no added detail beyond what DaySheet already surfaces on tap. Collapse them into a single chronological Agenda: the derived focus objective keeps its full card (milestones, coach strategy, generate-plan CTA), other dated objectives and upcoming activities are merged into one date-sorted list below. Also scopes the section to dated objectives only — the prior ObjectiveSection rendered ALL of active.objectives, which per the API includes standing (open-ended) goals, duplicating what the Status tab's GeneralObjectivesSection already shows for those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DaySheetalready shows on tap.ObjectiveSectionrendered all ofactive.objectives, which per the/objectives/activeAPI includes standing (open-ended) goals — duplicating what the Status tab'sGeneralObjectivesSectionalready shows for those. The newAgendaSectionscopes tokind === 'dated'only (except the focus card, which shows regardless of kind since it drives Generate Plan).+ Objective/+ Activityquick-add actions since the two flows open different sheets.Test plan
npx tsc -b— cleannpm run lint(oxlint) — clean (one pre-existing unrelated warning)npx vitest run— 141/141 passing across all 17 test files (updatedPlanPage.test.tsxfor the new merged empty-state/header-driven add flows)