[P1/low] refactor(metron): rename user-facing 'Advisor' to 'Intelligence'#217
Open
ne-groomer[bot] wants to merge 3 commits into
Open
[P1/low] refactor(metron): rename user-facing 'Advisor' to 'Intelligence'#217ne-groomer[bot] wants to merge 3 commits into
ne-groomer[bot] wants to merge 3 commits into
Conversation
…ron-ops#165) - Update user-visible strings: error messages, tier labels, nav breadcrumbs - Keep internal identifiers (AdvisorView, AdvisorProfile, /ext/advisor route, getAdvisor) - Update tests to reflect new terminology (tier-simulator, portfolio-nav, locked) - Add test_no_advisor_strings.py to lock the invariant: no user-facing 'Advisor' strings remain - Route /portfolios/[id]/advisor/* path stays unchanged (links still work, redirect preserved) Closes metron-ops#165 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ne-groomer
Bot
added
source:groom
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…igence The test plugin now uses the Intelligence label as part of the rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority: P1 · Complexity: low
Summary
Rename all user-facing 'Advisor' strings to 'Intelligence' to comply with Advisers Act compliance constraints (pre-registration surface must not self-describe as an advisor). Internal code identifiers (type names, API routes, entitlement keys) remain unchanged.
Changes
/portfolios/[id]/advisor/*unchanged (bookmarks preserved)Validation
npm run lint(ESLint/prettier)npm run build(Next.js TypeScript check)npm run test(vitest suite)ruff check(Python tests for test_no_advisor_strings.py)To validate locally:
Closes #165
Groom-Run: 1ac66fd741254c12bf6062d24cc91180