[P1/low] refactor(intelligence): rename user-facing 'Advisor' to 'Intelligence' (#165)#216
Open
ne-groomer[bot] wants to merge 2 commits into
Open
[P1/low] refactor(intelligence): rename user-facing 'Advisor' to 'Intelligence' (#165)#216ne-groomer[bot] wants to merge 2 commits into
ne-groomer[bot] wants to merge 2 commits into
Conversation
…igence Implements metron-ops#165 (Decision 1: user-facing name = 'Intelligence') by renaming all user-visible Advisor strings and routes while keeping internal identifiers (entitlements, packages) unchanged for backwards compatibility. Changes: - Route: /portfolios/[id]/advisor/ → /intelligence/ (old route redirects) - UI labels: 'AI Advisor' → 'Intelligence' tier label throughout - Component imports: generate-advisor.tsx now imports from intelligence/actions - Tests: updated test expectations for new 'Intelligence' labels Internal unchanged (code identity ≠ user-facing): - api/entitlements.py: ai_advisor key unchanged - metron_ext.advisor package name unchanged - SSM params (/metron/llm/advisor) unchanged Per config#1499 phase map (metron-ops#164 decision 1). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…igence The test plugin now uses the Intelligence label as part of the rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority: P1 · Complexity: low
Closes #165
Summary
Implements decision 1 of metron-ops#164 (Intelligence phase map) by renaming all user-facing 'Advisor' strings to 'Intelligence' while preserving internal package/entitlement identifiers for backwards compatibility.
Changes
User-facing (public strings):
/portfolios/[id]/advisor/→/intelligence/(old route redirects via next/navigation)guard-no-user-advisor-strings.test.tsprevents regression (grep-based, mirrors the yfinance guard pattern)Internal (unchanged for backwards compatibility):
api/entitlements.py:ai_advisorkey unchangedmetron_ext.advisorpackage name unchanged/metron/llm/advisor) unchangedadvisor-profile-form.tsxetc.) kept for internal clarityTesting
Before merge, run:
The guard test will fail if any user-facing "Advisor" strings slip through. Allowlist is defined for internal identifiers only.
Bookmarks & URLs
Old bookmarks to
/advisor/will redirect to/intelligence/(next/navigation redirect pattern). This is transparent to users.Gate: ready — all changes are straightforward renames + guard test
Closes #165.
Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com