refactor(refs): condense language-agent references to local knowledge (W-PR2) - #895
Merged
Conversation
… — python, golang, golang-compact, php 89:11 generic-to-local audit remediation. Deletes public-docs restatements (python-errors catalog, Go concurrency/testing/security tutorials, PHP security tutorial); keeps every host incident, operator convention, and version/CVE-pinned gotcha: - flask-jinja-webapp mode-600 nginx 403 incident, CSRF blueprint pins (verbatim) - reddit_mod except-OSError silent-failure gate, CLI pipeline conventions - Peewee E712 ruff exception; host venv/pip mismatch rule - GOMODCACHE library-source verification; rebuilt-binary stat check; hermes/log-router deadcode A/B result; Go 1.18-1.26 idiom tables - PHP PostToolUse hook block, SAP Commerce context, hard gates Defects fixed: - python-modern-features.md shipped 'curl | sh' uv installer (violates home installer policy) -> pipx/pip install path - php-security.md justified PHP prepared statements with 'Sequelize CVE-2023-25813' (a Node ORM CVE) -> bogus citation dropped - php loading table rows 1-3 had file links in the Signal column -> keyword signals restored Prunes go-errors.md and python-preferred-patterns.md from _KNOWN_OVERSIZED. python: 10,005 -> 1,456 words (12 -> 2 files) golang: 11,793 -> 1,217 (10 -> 2) golang-compact: 3,183 -> 545 (3 -> 1) php: 4,581 -> 1,638 (4 -> 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track W, PR2 of 7. Remediates the 89:11 generic-to-local ratio for the four language agents. Per the mandate, this merges and condenses — every agent keeps its
references/dir and at least one file. No agent deleted.Measured
Agent-references corpus: 225,511 -> 200,805 words.
Cut
Public-docs restatements a frontier model has cold: the python-errors exception catalog, Go concurrency/testing/security tutorials, the PHP security tutorial,
goplsworkflow narration, motivational preamble, and placeholder-entity examples.Preserved (local knowledge, the actual asset)
flask-jinja-webapp.mdmode-600 -> nginx 403 incident, verbatim, plus the gunicorn template-cache restart rule and CSRF blueprint-exemption pinsreddit_mod.pyexcept OSError: passsilent-failure gatestatstaleness check; hermes/log-router dead-code A/B result; Go 1.18-1.26 version idiom tablesDefects fixed in passing
python-modern-features.mdshippedcurl -LsSf https://astral.sh/uv/install.sh | sh— violates the homeCLAUDE.mdinstaller policy. Replaced with a pipx/pip path.php-security.mdjustified PHP prepared statements by citing Sequelize CVE-2023-25813, a Node ORM CVE. Bogus citation dropped. (The correct Node-context citation inreviewer-systemis untouched.)golang-general-engineer-compactlistedgo-patternstwice in Companion Skills; merged to one row.Gates (local, ruff 0.15.12 matching CI)
ruff checkpass -ruff format --check583 files pass -validate-references.py --check-do-framingpass ---check-placeholderspass -validate_reference_loading_tables.pyexit 0 -pytest scripts/tests/ -q4735 passed, 1 skipped, 139 xfailed.--allstructure issues improve 7 agents/15 issues -> 5/10; all residual flags areNO_CODE_EXAMPLESadvisories on agents this PR does not touch.Pruned 2 now-deleted entries from
_KNOWN_OVERSIZED_SKILL_REFS(go-errors.md,python-preferred-patterns.md), per the same-PR rule.Note, out of scope
agents/INDEX.jsondrift warning (43 indexed vs 44.mdon disk) is pre-existing on main and a false positive:base-instructions.mdis a shared include, correctly excluded by the generator while the hook counts raw files.