Skip to content

chore: make CRD image Trivy scan warning only#2575

Merged
susanshi merged 8 commits into
notaryproject:release-1.4from
fseldow:chore-crd-trivy-warning-release-1.4
Jun 17, 2026
Merged

chore: make CRD image Trivy scan warning only#2575
susanshi merged 8 commits into
notaryproject:release-1.4from
fseldow:chore-crd-trivy-warning-release-1.4

Conversation

@fseldow

@fseldow fseldow commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Make Trivy scans for the CRD image warning-only while keeping the Ratify server image scan blocking.

Motivation

The CRD image bundles upstream kubectl, which can carry Go stdlib CVE findings until Kubernetes publishes a patched kubectl build. These findings should remain visible in CI logs, but should not block Ratify changes. The Ratify server image still fails CI on HIGH/CRITICAL vulnerabilities.

Changes

  • Split the blocking image scan step so only the Ratify server image uses --exit-code 1
  • Add a separate CRD image HIGH/CRITICAL Trivy scan without --exit-code 1

Validation

  • Parsed .github/workflows/scan-vulns.yaml as YAML successfully.

Keep the Ratify server image HIGH/CRITICAL Trivy scan blocking, but report CRD image findings without failing CI because the CRD image bundles upstream kubectl.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: xinhl <xinhl@microsoft.com>
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.73%. Comparing base (b413348) to head (b7c207a).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.4    #2575   +/-   ##
============================================
  Coverage        74.73%   74.73%           
============================================
  Files              138      138           
  Lines             6904     6904           
============================================
  Hits              5160     5160           
  Misses            1372     1372           
  Partials           372      372           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charleswool charleswool left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

susanshi
susanshi previously approved these changes Jun 12, 2026
Ignore existing external documentation links that return 403 to GitHub Actions link checking while remaining accessible or intentionally external.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: xinhl <xinhl@microsoft.com>
Signed-off-by: xinhl <xinhl@microsoft.com>
@fseldow fseldow force-pushed the chore-crd-trivy-warning-release-1.4 branch from 0257726 to c3c606b Compare June 17, 2026 05:43
Signed-off-by: xinhl <xinhl@microsoft.com>
Signed-off-by: xinhl <xinhl@microsoft.com>
Signed-off-by: xinhl <xinhl@microsoft.com>
Signed-off-by: xinhl <xinhl@microsoft.com>
@susanshi susanshi merged commit 6f689ee into notaryproject:release-1.4 Jun 17, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants