Fix version-info for 8.9.0 and drop release#11
Open
kwizart wants to merge 1 commit into
Open
Conversation
Author
|
Side note, rpmsodiff show that library ABI isn't compatible (symbols are removed), so there is indeed a need to change the SONAME, but it wasn't done in the 8.9.0 autotools release. |
Collaborator
|
We have no automatic testing on PRs? |
This will lead to a libcryptopp.so.9 SONAME and libcryptopp.so.9.0.0 library.
f866c60 to
7161088
Compare
Author
|
Seems like I've pushed the wrong patch, force-pushed. Alternative is more likely to use libcryptopp-8.9.0.so.0 (for 8.9.0) and rely on the same variable that defines the major version. But this isn't the usual way to define the SONAME on linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will lead to a libcryptopp.so.9 SONAME and libcryptopp.so.9.0.0 library.