security(#305): gitignore session profiles/spool; drop hardcoded operator paths#315
Draft
nolanmak wants to merge 2 commits into
Draft
security(#305): gitignore session profiles/spool; drop hardcoded operator paths#315nolanmak wants to merge 2 commits into
nolanmak wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ator paths Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
203d81e to
8f1df3b
Compare
….homedir (no hardcoded home) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #305.
Prevents committing live session-cookie profiles/spools and removes committed operator PII (which also broke macOS).
.gitignore: adds**/chrome-profile/,**/*-chrome-profile/,.env.*,augmentagent-webhooks.jsonl,augmentagent-deft-seen.jsonl(verified viagit check-ignore).sidecars/grocery/src/server.ts:SCHEDULE_HELPER/NODE_BINnow env/process.execPath-derived (fixes macOS).systemd/*.service(×5): hardcoded/home/nolan-makatche→%h.reasoner.rs: operator name scrubbed from a test fixture (path shape preserved so sanitizer tests still hold).No Linux behavior change; grocery paths now resolve on macOS too.
Verification:
git check-ignoreconfirms all 5 patterns ignored;cargo check -p augmentagent-channel-corepasses.Follow-up (out of scope):
scripts/grocery-schedule.mjsstill has/home/nolan-makatchepaths (theWEEKLY_SCRIPTconst + embedded unit templates) — derive fromimport.meta.url/os.homedir()in a follow-up.🤖 swarm-authored, human-review-required (draft).