security(#304): SSRF denylist for fetch sidecar and CardDAV#314
Draft
nolanmak wants to merge 1 commit into
Draft
security(#304): SSRF denylist for fetch sidecar and CardDAV#314nolanmak wants to merge 1 commit into
nolanmak wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #304.
Adds an SSRF denylist to server-side fetches.
sidecars/fetch/src/ssrf.ts:assertUrlAllowed(scheme check +dns.lookup({all})+ IPv4/IPv6 private-range classifier) andsafeFetch(manual-redirect loop re-validating each hop, redirect cap 10). Blocks loopback, link-local, RFC1918, unique-local, 0.0.0.0, CGNAT, IPv4-mapped IPv6, and cloud metadata (169.254.169.254), plus all non-http(s) schemes incl.file://. Wired intolayers/http.ts,layers/render.ts(Playwrightcontext.routeper-hop re-validation + final-URL check), andfetcher.ts(up-front gate).carddav.rs: absolute<href>s are followed only when their host matches the configured CardDAV host (userinfo stripped to preventuser@hostspoofing); others skipped. +2 unit tests.Public URLs and normal same-host CardDAV behavior preserved.
Verification: fetch sidecar
npm install+npx tsc --noEmitexit 0;cargo check -p augmentagent-channel-contactsclean.Honest caveat: the Playwright render layer gates
document-type requests; a DNS-rebind between the route check and the browser's own socket connect is a theoretical residual only a lower-level resolver hook could fully close.🤖 swarm-authored, human-review-required (draft).