This repository was archived by the owner on May 12, 2026. It is now read-only.
Parse dekstop files using Gio.DesktopAppInfo - #677
Merged
Conversation
aleasto
marked this pull request as draft
May 8, 2026 14:28
Drop the custom parsing of desktop files in favour of the implementation in GLib. This gives us the benefit of supporting localizations on distros with langpacks like Ubuntu (albeit through a downstream patch in GLib). Assisted-by: GitHub Copilot (GPT-5.4)
aleasto
marked this pull request as ready for review
May 8, 2026 14:59
Owner
|
Looks good, thanks a lot! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the custom parsing of desktop files in favour of the implementation in GLib.
This gives us the benefit of supporting localizations on distros with langpacks like Ubuntu (albeit through a downstream patch in GLib).
Assisted-by: GitHub Copilot (GPT-5.4)