-
Notifications
You must be signed in to change notification settings - Fork 10
Fix prerequisites in the documentation #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
migrym
wants to merge
5
commits into
nokia:main
Choose a base branch
from
migrym:fix-prerequisites
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d18c37a
Fix prerequisites in the documentation
migrym f266d4f
Clarify nFPM is needed when building packages locally
migrym cea8798
Control the packages created by docker build with build args
migrym 6365eab
Fix typo, align code example style
migrym 2e383bd
Merge branch 'nokia:main' into fix-prerequisites
migrym File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more extensive description on how to get the binary and install it in a directory in your path is probably required
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is fine; although I would prefer to use the tag
latest, as in:Also, lets try to follow the convention of using
bashas the highlighting schema in fenced code blocks that illustrate command line invocations, and prefix them with$. i.e the above should be written as:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the tag also changes the Go version it requires, I opted to pin the versions in the prerequisites here, though
go installworks regardless. As for the prompt, I avoid it because pressing the copy button will not copy just the the command part, so you will need to paste and edit before running it.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed to follow the convention throughout the README, but please consider if removing the prompt would better facilitate copy-pasting the code block commands.
Please comment if you still want to opt for the latest nFPM version when installing.