Improve scheduler coverage for AWS Batch and MPI edge/error paths#351
Draft
Copilot wants to merge 7 commits into
Draft
Improve scheduler coverage for AWS Batch and MPI edge/error paths#351Copilot wants to merge 7 commits into
Copilot wants to merge 7 commits into
Conversation
Agent-Logs-Url: https://github.com/noisepy/NoisePy/sessions/b7d23d73-d5e2-4782-9e78-9d9acfa30b3c Co-authored-by: niyiyu <36231703+niyiyu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/noisepy/NoisePy/sessions/b7d23d73-d5e2-4782-9e78-9d9acfa30b3c Co-authored-by: niyiyu <36231703+niyiyu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/noisepy/NoisePy/sessions/b7d23d73-d5e2-4782-9e78-9d9acfa30b3c Co-authored-by: niyiyu <36231703+niyiyu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/noisepy/NoisePy/sessions/b7d23d73-d5e2-4782-9e78-9d9acfa30b3c Co-authored-by: niyiyu <36231703+niyiyu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/noisepy/NoisePy/sessions/b7d23d73-d5e2-4782-9e78-9d9acfa30b3c Co-authored-by: niyiyu <36231703+niyiyu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/noisepy/NoisePy/sessions/b7d23d73-d5e2-4782-9e78-9d9acfa30b3c Co-authored-by: niyiyu <36231703+niyiyu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/noisepy/NoisePy/sessions/b7d23d73-d5e2-4782-9e78-9d9acfa30b3c Co-authored-by: niyiyu <36231703+niyiyu@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
niyiyu
May 11, 2026 21:33
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets uncovered scheduler branches identified during coverage analysis, focusing on failure and boundary behavior that was not exercised by existing tests. It adds focused unit tests for AWS Batch array metadata/index handling and MPI scheduler initialization/work allocation edge cases.
Coverage gaps addressed
AWSBatchArraySchedulererror paths:arrayProperties.sizein AWS Batch parent job metadataAWS_BATCH_JOB_ARRAY_INDEXMPIScheduleredge behavior:shared_varsand initializer return sizeTest isolation improvements
scheduler/constantsdirectly from source when package-level imports are unavailable in lightweight environments.New test module
tests/test_scheduler_additional.pyExample of one of the added edge-case checks: