quic: validate :path in sendHeaders - #64936
Open
Archkon wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64936 +/- ##
=========================================
Coverage 90.28% 90.29%
=========================================
Files 760 759 -1
Lines 247061 248308 +1247
Branches 46592 46853 +261
=========================================
+ Hits 223058 224201 +1143
- Misses 15491 15522 +31
- Partials 8512 8585 +73
🚀 New features to boost your workflow:
|
Reject invalid :path values before passing headers to nghttp3. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
jasnell
reviewed
Aug 7, 2026
| if (value[0] !== '/' && value !== '*') { | ||
| throw new ERR_INVALID_ARG_VALUE( | ||
| 'headers.:path', path, 'must start with "/"'); | ||
| } |
Member
There was a problem hiding this comment.
I'm not convinced this is the correct place for this validation. It is http specific while sendHeaders here could apply to other quic applications in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64924