src: remove unused using declarations in node_task_queue#63144
Open
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
Open
src: remove unused using declarations in node_task_queue#63144mertcanaltin wants to merge 2 commits intonodejs:mainfrom
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
nodejs-github-bot
added
c++
panva
approved these changes
May 6, 2026
Contributor
|
Fast-track has been requested by @panva. Please 👍 to approve. |
Collaborator
panva
added
author ready
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added
the
author ready
panva
approved these changes
May 6, 2026
Collaborator
targos
approved these changes
May 6, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63144 +/- ##
==========================================
- Coverage 91.48% 89.67% -1.81%
==========================================
Files 361 713 +352
Lines 155193 224076 +68883
Branches 23949 42311 +18362
==========================================
+ Hits 141977 200947 +58970
- Misses 12943 14951 +2008
- Partials 273 8178 +7905
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from #62336 which removed the references but kept the
usingdeclarations.tools/checkimports.pyflags them as unused on every CI run.