feat: add memo param to TxBuilder#11
Open
nocktoshi wants to merge 13 commits into
Open
Conversation
borngraced
reviewed
Dec 15, 2025
… ensuring memo is applied to the last seed of the best lock-root
Contributor
|
Finally had time to look at this. If we are to support a standard for text encoding, it should be optimal. Few issues I can see:
Both of these add up to transaction cost. If the following can be done to cut costs, they should be done. At that point, the standard can be adopted by the wallet officially. |
Contributor
|
@nocktoshi there is now efficient and compact atom<->belts conversion https://github.com/nockbox/iris-rs/blob/main/crates/iris-wasm/src/noun.rs#L48 |
# Conflicts: # Cargo.lock # Cargo.toml # crates/iris-grpc-proto/src/convert.rs # crates/iris-nockchain-types/src/tx_engine/builder.rs # crates/iris-nockchain-types/src/tx_engine/note.rs # crates/iris-nockchain-types/src/tx_engine/tx.rs # crates/iris-wasm/src/tx.rs
- Updated `seeds_to_pb` function to handle `NoteData` from the new module. - Refined `From` implementation for `PbNoteData` to use tuple destructuring. - Removed unused memo handling code from `SpendBuilder` and `TxBuilder`. - Simplified memo encoding in `encode_utf8_string_memo` to use a more efficient format. - Cleaned up imports and removed deprecated structures related to memo handling.
- Introduced `push_memo` and `push_blob` methods for inserting memo and blob nouns. - Added `push_memo_utf8` method to encode UTF-8 strings as compact belts nouns. - Enhanced the NoteData structure to support new memo handling functionality.
Contributor
Author
|
@h33p I have updated the pr to use the new atom<->belts conversion in How does it look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to send a memo with the wasm builder.
Note: I still need to update iris UI to show the memo when signing. For now it works by blind signing.
Txn from Iris: https://nockblocks.com/tx/BkcNhQcSmRjQygQ4wYTLFh6WVKmSyNbKFCcKVyBYkZNUDzjwxUEfidh
Usage: