feat(react-utils)!: add render block wrapper option#775
Open
maeertin wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 590b441 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 70.42% 70.60% +0.17%
==========================================
Files 66 66
Lines 1055 1058 +3
Branches 265 266 +1
==========================================
+ Hits 743 747 +4
Misses 248 248
+ Partials 64 63 -1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates @noaignite/react-utils’s createRenderBlock to remove the built-in ErrorBoundary/Suspense composition and instead let consumers explicitly wrap rendered blocks via a new wrapper option.
Changes:
- Removed the default
ErrorBoundary/Suspensewrapping and thefallbackoption fromcreateRenderBlock. - Added a
wrapper({ children }, context, globals)option (plusRenderBlockWrappertype) to allow custom block composition. - Updated tests, docs, and added a major-version changeset describing the breaking change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react-utils/src/createRenderBlock.tsx | Replaces built-in boundary/suspense wrapping with an optional wrapper callback and adjusts prop shaping. |
| packages/react-utils/src/createRenderBlock.test.tsx | Updates tests to validate wrapper behavior and new error propagation behavior. |
| packages/react-utils/skills/react-utils/component-factories-and-block-rendering/SKILL.md | Updates documentation to describe wrapper-based composition. |
| .changeset/fresh-ducks-warn.md | Declares a major release and documents the breaking API change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maeertin
force-pushed
the
feat/react-utils-createRenderBlock-wrapper
branch
from
ee80e78 to
a576421
Compare
maeertin
force-pushed
the
feat/react-utils-createRenderBlock-wrapper
branch
from
a576421 to
1dbd091
Compare
maeertin
force-pushed
the
feat/react-utils-createRenderBlock-wrapper
branch
from
1dbd091 to
5545eed
Compare
maeertin
force-pushed
the
feat/react-utils-createRenderBlock-wrapper
branch
from
5545eed to
b6e6b85
Compare
maeertin
force-pushed
the
feat/react-utils-createRenderBlock-wrapper
branch
from
b6e6b85 to
198693d
Compare
maeertin
force-pushed
the
feat/react-utils-createRenderBlock-wrapper
branch
from
198693d to
af4c02e
Compare
maeertin
force-pushed
the
feat/react-utils-createRenderBlock-wrapper
branch
from
af4c02e to
590b441
Compare
maeertin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.