chore: benchmark workflow - #238
Draft
syi0808 wants to merge 1 commit into
Draft
Conversation
noahbald
reviewed
Jul 6, 2026
Owner
There was a problem hiding this comment.
Can we stick to just the nu file?
noahbald
reviewed
Jul 6, 2026
| @@ -1,15 +1,51 @@ | |||
| def main [] { | |||
| # Files are picked from https://svgo.dev/docs/plugins/sortAttrs/ docs | |||
Owner
There was a problem hiding this comment.
Can you please preserve this comment
noahbald
reviewed
Jul 6, 2026
| CARGO_TERM_COLOR: always | ||
|
|
||
| jobs: | ||
| bench-base: |
Owner
There was a problem hiding this comment.
I think instead of running base-bench for every PR, we should be able to get cached results of the latest merged PR.
noahbald
reviewed
Jul 6, 2026
| HEAD_RESULTS: ${{ needs.bench-head.outputs.results }} | ||
| BENCHMARK_THRESHOLD_PERCENT: "5" | ||
| run: | | ||
| node .github/scripts/criterion-report.mjs report > benchmark-report.md |
Owner
There was a problem hiding this comment.
I think it would be simpler to use the stdout generated by criterion as-is; one less thing to maintain.
syi0808
marked this pull request as draft
July 7, 2026 01:09
Contributor
Author
|
Sorry, this pr was opened by mistake. I meant to target the main branch of my forked repo, but i accidentally selected wrong branch. |
noahbald
force-pushed
the
main
branch
2 times, most recently
from
July 23, 2026 02:12
51d5b96 to
7d72b08
Compare
noahbald
force-pushed
the
main
branch
3 times, most recently
from
August 10, 2026 05:06
aec012b to
73231ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Fixes
Features
Breaking changes
Checklist: