Add reset() to the terminal controller#1
Merged
Conversation
Expose xterm's full `reset()` alongside `clear()` on the controller. `clear()` wipes scrollback but keeps the prompt line; `reset()` blanks the screen entirely, which apps want when starting a fresh session. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
TerminalControllerexposesclear()but not xterm's fullreset().clear()only wipes scrollback while keeping the current prompt line, so there is no way to blank the screen entirely — what an app wants when starting a fresh session.Change
Add
reset()to the controller, forwarding to xterm'sTerminal.reset():types.ts—reset: () => voidonTerminalController, plus a doc line on each clearing method noting theclearvsresetdistinction.use-xterm.ts— wireresetinto the stable handle next toclear.README.md— documentresetin the controller surface.Ported from downstream usage where a "new session" action needed a full blank, not just a scrollback clear. Typecheck and
tsupbuild pass.🤖 Generated with Claude Code