Skip to content

[Fix]: remove grouping override #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Schiano-NOAA wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix]: remove grouping override #282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cd1fa
remove override of group when not recognized since check grouping is …
Schiano-NOAA Jun 24, 2026
f82a2a8
add condition for group being added to index_variables when added as arg
Schiano-NOAA Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions R/process_data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,19 +115,20 @@ process_data <- function(
}
}
# Warn user when group not indexed in data
if (!is.null(group) && group %notin% index_variables) {
if (group != "none") {
cli::cli_alert_warning("{group} not an index of data.")
# reset group to NULL so it's not added to grouping incorrectly
group <- NULL
}
}
# if (!is.null(group) && group %notin% index_variables) {
# if (group != "none") {
# cli::cli_alert_warning("{group} not an index of data.")
# # reset group to NULL so it's not added to grouping incorrectly
# group <- NULL
# }
# }
# Set group_var to identified grouping
if (!is.null(group) && group != "none") {
data <- dplyr::mutate(
dat,
group_var = .data[[group]]
)
if (group %notin% index_variables) index_variables <- c(group, index_variables)
} else {
data <- dat
}
Expand Down
Loading