fix complete for do_forecast==0#765
Merged
Merged
Conversation
iantaylor-NOAA
approved these changes
Jun 18, 2026
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
Contributor
There was a problem hiding this comment.
Look good. Thank you @Rick-Methot-NOAA.
You solved this much faster and more simply than I could have figured this one out on my own.
Contributor
|
Note: this fixes #764 |
Collaborator
Author
|
@e-perl-NOAA Please rebase and merge, unless that might interfere with final merge of the growth fix |
e-perl-NOAA
force-pushed
the
re-enable-simple-1yr-forecast
branch
from
5e35314 to
e32a4c0
Compare
Collaborator
|
The growth stuff has already been merged into main for the pre-release, so this can be merged fine. |
Rick-Methot-NOAA
added
change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
do_forecast==0 was broken when saving of HCR_anchor was added to mgmt_quant. Fix provided here.
What tests have been done?
model now runs when do_forecast==0
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
Is there an input change for users to Stock Synthesis?
Additional information (optional).