[feat] Check and fix duplicated figure/table chunk labels#486

Open

sbreitbart-NOAA wants to merge 20 commits into

mainfrom

plot-checks

Commits on Jun 22, 2026

Create function that checks for duplicated chunk labels in fig/table docs, and if present, comments out duplicates (as per https://github.com/nmfs-ost/asar/issues/451)

sbreitbart-NOAA
authored and
Schiano-NOAA
committed
Update tests

sbreitbart-NOAA
authored and
Schiano-NOAA
committed
add check for current figures and remove from loop if present already in figures doc
Schiano-NOAA
committed
remove test and add comment for duplicate chunks
Schiano-NOAA
committed
add check and adjust conditions for messages when checking for previous tabs are added
Schiano-NOAA
committed
adjust the condition when the set up chunk gets added
Schiano-NOAA
committed
adjust create_figures_docs to work and pass checks
Schiano-NOAA
committed
change message when figures/tables doc doesn't have any objects to add
Schiano-NOAA
committed
update messages when new figures are added vs initial creation with figs
Schiano-NOAA
committed
add new test for duplicate figs
Schiano-NOAA
committed
comment out dup chunk check since no longer applies and add TODO; add initial creation of object for later message associated with new figureson remake doc
Schiano-NOAA
committed
update create_tables_doc to reflect the same changes done for create_figures_doc
Schiano-NOAA
committed
correct tests and comment out moot test
Schiano-NOAA
committed
make new test testing capability of create_tables_doc adding another table in doc when one was already present
Schiano-NOAA
committed
adjust test to create snapshot instead of expect equal
Schiano-NOAA
committed
move create_tab_chunks into utils
Schiano-NOAA
committed
move create_fig_chunks out of fxn and into utils
Schiano-NOAA
committed

Commits on Jun 23, 2026

Commits on Jun 24, 2026

update tests for figures and tables docs fxns to create snapshot and work
Schiano-NOAA
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[feat] Check and fix duplicated figure/table chunk labels#486

[feat] Check and fix duplicated figure/table chunk labels#486
sbreitbart-NOAA wants to merge 20 commits into
mainfrom
plot-checks

Commits on Jun 22, 2026

Create function that checks for duplicated chunk labels in fig/table docs, and if present, comments out duplicates (as per https://github.com/nmfs-ost/asar/issues/451)

Update tests

add check for current figures and remove from loop if present already in figures doc

remove test and add comment for duplicate chunks

add check and adjust conditions for messages when checking for previous tabs are added

adjust the condition when the set up chunk gets added

adjust create_figures_docs to work and pass checks

change message when figures/tables doc doesn't have any objects to add

update messages when new figures are added vs initial creation with figs

add new test for duplicate figs

comment out dup chunk check since no longer applies and add TODO; add initial creation of object for later message associated with new figureson remake doc

update create_tables_doc to reflect the same changes done for create_figures_doc

correct tests and comment out moot test

make new test testing capability of create_tables_doc adding another table in doc when one was already present

adjust test to create snapshot instead of expect equal

move create_tab_chunks into utils

move create_fig_chunks out of fxn and into utils

Commits on Jun 23, 2026

Revert "move create_fig_chunks out of fxn and into utils"

Revert "move create_tab_chunks into utils"

Commits on Jun 24, 2026

update tests for figures and tables docs fxns to create snapshot and work