fix(constants.js): updated job card selector#93
Merged
Conversation
Collaborator
|
@priverop Thanks for the fix, I think keeping both would be better for robustness Linkedin love to do progressive feature rollouts |
Contributor
Author
|
@valdoryu done! Tested and it works fine. Feel free to @ me if this breaks again (I'll try to look it up from time to time). |
valdoryu
approved these changes
May 27, 2026
Collaborator
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current selector doesn't exist anymore:
I changed it for ".job-card-container" and it works fine:
If we wanted to make it more robust, we could add more selectors to that JOB_SELECTORS array
export const JOB_SELECTORS = ['.job-card-container', 'div[data-job-id]']because querySelectorAll won't choose the same node twice. In case Linkedin changes it again. Let me know if you prefer this one!I don't mind changing this in the future if it breaks again, if I get a @... It's just a one liner.