Replace libsndfile with pydub#12
Open
gryffyn wants to merge 7 commits into
Open
Conversation
libsndfile is very limited in what codecs it can read. pydub supports everything ffmpeg does, and given that users will need pydub anyways for any type of lossless codec, removing a dependency and using one solution for all codecs is simpler. This also replaces mutagen with tinytag, which is simpler to use and also helpfully returns the bitrate and codec name. Signed-off-by: gryffyn <me@gryffyn.io>
Signed-off-by: gryffyn <me@gryffyn.io>
Signed-off-by: gryffyn <me@gryffyn.io>
Signed-off-by: gryffyn <me@gryffyn.io>
Signed-off-by: gryffyn <me@gryffyn.io>
Signed-off-by: gryffyn <me@gryffyn.io>
Signed-off-by: gryffyn <me@gryffyn.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libsndfileis very limited in what codecs it can read.pydubsupports everything ffmpeg does, and given that users will need pydub anyways for any type of lossless codec, removing a dependency and using one solution for all codecs is simpler.This also replaces mutagen with tinytag, which is simpler to use and also helpfully returns the bitrate and codec name.
All tests pass, they were rewritten to use pydub and scipy to generate the wav/flac files though, however the actual samples are the same.
Signed-off-by: gryffyn me@gryffyn.io