Fix/termios from bits retain#2799
Open
snltd wants to merge 7 commits into
Open
Conversation
In case there are any unrecognised bits, they should be kept when setting fields of the underlying libc termios struct in get_libc_termios, rather than being dropped. This ensures that termios can be roundtripped even with unrecognised bits set.
|
Added termios.rs file patch to the fish build package in OpenIndiana. OpenIndiana/oi-userland@6a92fb9 I can confirm that fish now works with the patch to the nix crate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
This is a rebase of @qwandor 's work in #2253 to fix bad termios behaviour on illumos. Not only does it fix the code sample in #2071 , but I was able to build fish 4.7.1 on illumos with my locally patched nix, and have it work fine. (Previously the term got torn down immediately, which is how I found this problem.)
All credit to @qwandor and @nospam3089. All I did was cherry pick some commits.
Checklist:
CONTRIBUTING.md