Skip to content

ci: added treefmt workflow to gha and removed from buildbot#3611

Merged
MattSturgeon merged 1 commit into
nix-community:mainfrom
c4patino:ci/treefmt
Aug 20, 2025
Merged

ci: added treefmt workflow to gha and removed from buildbot#3611
MattSturgeon merged 1 commit into
nix-community:mainfrom
c4patino:ci/treefmt

Conversation

@c4patino

@c4patino c4patino commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Seemed like low hanging fruit in #3561

  • Migrates the treefmt foramtting check from buildbot to a dedicated Github Actions workflow.
  • Removes the buildbot treefmt check from flake/dev/fmt.nix to avoid duplicate runs with the new formatter.

@MattSturgeon MattSturgeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Comment thread .github/workflows/treefmt.yml Outdated
Comment thread .github/workflows/treefmt.yml Outdated
@c4patino c4patino requested a review from MattSturgeon August 9, 2025 14:17
@c4patino

Copy link
Copy Markdown
Contributor Author

Hi @MattSturgeon is there anything else that you need on this?

@MattSturgeon MattSturgeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is complicated a little by merge queues and "required status checks", however I'm fine merging this initially without adding it as a "required" check.

#3628 can then be responsible for implementing the required checks for PRs and merge queues.

A few minor things to address or discuss below, then I think we can get this merged.

Thanks again!

Comment thread .github/workflows/treefmt.yml Outdated
Comment thread .github/workflows/treefmt.yml
Comment thread .github/workflows/treefmt.yml Outdated
Comment thread .github/workflows/treefmt.yml Outdated
@c4patino c4patino requested a review from MattSturgeon August 18, 2025 21:56

@MattSturgeon MattSturgeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MattSturgeon MattSturgeon added this pull request to the merge queue Aug 20, 2025
Merged via the queue into nix-community:main with commit cfdbf72 Aug 20, 2025
5 checks passed
@nixvim-ci

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants