Skip to content

feat: verify github url before updating (fixes #552) #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lnk3 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: verify github url before updating (fixes #552) #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82af250
urlReachable: stub new function and call site
lnk3 Jun 17, 2026
5ab9e23
urlReachable: use Network.HTTP.Client to make a HEAD request to github
lnk3 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/GH.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module GH
authFromToken,
checkExistingUpdatePR,
closedAutoUpdateRefs,
urlReachable,
compareUrl,
latestVersion,
pr,
Expand All @@ -19,6 +20,7 @@ module GH
where

import Control.Applicative (liftA2, some)
import Control.Exception (try)
import Data.Aeson (FromJSON)
import Data.Bitraversable (bitraverse)
import qualified Data.Text as T
Expand All @@ -28,7 +30,8 @@ import qualified Data.Vector as V
import qualified Git
import qualified GitHub as GH
import GitHub.Data.Name (Name (..))
import Network.HTTP.Client (HttpException (..), HttpExceptionContent (..), responseStatus)
import Network.HTTP.Client
import Network.HTTP.Client.TLS (tlsManagerSettings)
import Network.HTTP.Types.Status (statusCode)
import OurPrelude
import Text.Regex.Applicative.Text ((=~))
Expand Down Expand Up @@ -149,6 +152,20 @@ parseURLMaybe url =
)
in url =~ regex

urlReachable :: Text -> IO Bool
urlReachable url =
case parseRequest $ T.unpack url of
Nothing -> pure False
Just req -> do
manager <- newManager tlsManagerSettings
res <-
try $
(httpNoBody (req {method = "HEAD"}) manager) ::
IO (Either HttpException (Response ()))
case res of
Left _ -> pure False
Right resp -> pure $ statusCode (responseStatus resp) == 200

parseURL :: MonadIO m => Text -> ExceptT Text m URLParts
parseURL url =
tryJust ("GitHub: " <> url <> " is not a GitHub URL.") (parseURLMaybe url)
Expand Down
6 changes: 6 additions & 0 deletions src/Update.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,12 @@ updateAttrPath log mergeBase updateEnv@UpdateEnv {..} attrPath = do
"The derivation has no 'version' attribute, so do not know how to figure out the version while doing an updateScript update"
(not hasUpdateScript || isJust oldVerMay)

unless hasUpdateScript $
when (T.isInfixOf oldVersion oldSrcUrl) do
let url = oldVersion `T.replace` newVersion $ oldSrcUrl
reachable <- liftIO $ GH.urlReachable url
unless reachable $ throwE ("The new url doesn't exist: " <> url)

-- One final filter
Skiplist.content derivationContents

Expand Down