Add source diff links for non-GitHub forges#533
Open
KiaraGrouwstra wants to merge 1 commit into
Open
Conversation
Previously, compare URLs in PR descriptions only worked for GitHub-hosted sources. Add a Forge module that parses source URLs and generates compare links for GitLab (including self-hosted), Codeberg/Gitea, and SourceHut. The GitHub compare URL path (via GH.compareUrl using the GitHub API) is tried first; Forge.compareUrl is used as a pure fallback for all forges. The link text is generalized from "on GitHub" to "upstream".
KiaraGrouwstra
force-pushed
the
forge-compare-urls
branch
from
a4b3382 to
e9f6424
Compare
Member
|
There are quite a few issues with this code, but I don't know whether, if I were to write a review, I would be helping a human to learn Haskell (possibly worth my time) or giving a human some instructions that they would then feed to a coding agent to generate the next iteration of this PR (absolutely not worth my time). But I would not merge this as-is. |
Author
|
thanks for checking with me. to answer your question, it's thru haskell that i got into nix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, compare URLs in PR descriptions only worked for GitHub-hosted sources. Add a Forge module that parses source URLs and generates compare links for GitLab (including self-hosted), Codeberg/Gitea, and SourceHut.
The GitHub compare URL path (via
GH.compareUrlusing the GitHub API) is tried first; Forge.compareUrl is used as a pure fallback for all forges. The link text is generalized from "on GitHub" to "upstream".closes #516.
disclaimer i used a coding agent in the creation of this patch.