Use workspace/executeCommand instead of codeAction/resolve to be spec compliant#836
Open
JojOatXGME wants to merge 1 commit into
Open
Use workspace/executeCommand instead of codeAction/resolve to be spec compliant#836JojOatXGME wants to merge 1 commit into
workspace/executeCommand instead of codeAction/resolve to be spec compliant#836JojOatXGME wants to merge 1 commit into
Conversation
JojOatXGME
changed the title
workspace/executeCommand CodeAction execution instead of codeAction/resolve to be spec compliantworkspace/executeCommand instead of codeAction/resolve to be spec compliant
Author
|
Looks like I would need to adjust some tests. Unfortunately, I am not sure how to run the tests locally because I run into compile errors unrelated to my changes caused by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
codeAction/resolvewithworkspace/executeCommandfor action callbacks.While this might not be the cleanest implementation, I should demonstrate how I think this functionality should be implemented to stay compliant to the LSP specification.
Fixes #818