feat(diagnostics): add wrong/empty enum Value diagnostic#809
Open
cw-1988 wants to merge 1 commit into
Open
Conversation
inclyc
reviewed
Apr 15, 2026
inclyc
left a comment
inclyc
left a comment
Member
There was a problem hiding this comment.
This PR only validates whether enum values exist within the type system, but it skips other types in lib.type like bool or string. I'm concerned that checking only enums might be a bit 'heavy' in terms of performance impact. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#805, completions on top are added in #810
AI slopped with GPT-5.4 High, but a basic DX feature i had to add.
Take your time, read at your own pace, this issue isnt going anywhere.
I will use my own fork with the features i deem necessary. I'm just here to share the goods. Make all the edits you want, or give me the necessary feedback so i can improve upon this PR.
I hope you are doing well and have a nice day ;-)