feat(code-action): add quickfix to remove redundant parentheses#788
Closed
takeokunn wants to merge 1 commit into
Closed
feat(code-action): add quickfix to remove redundant parentheses#788takeokunn wants to merge 1 commit into
takeokunn wants to merge 1 commit into
Conversation
- Mark redundant parentheses diagnostics as preferred quickfix - Add tests for basic, multiline, and nested redundant paren cases - Ensure no action is offered when parentheses are required
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add code action to remove redundant parentheses from Nix expressions.
Example Transformation:
(1)1((1))(1)then1(two separate actions)(x)x({ }){ }Changes
nixd/lib/Controller/CodeAction.cppisPreferred: truefor redundant paren quickfixBehavior
Action offered when:
Action NOT offered when:
Handles removal:
(and)with twoTextEdit::mkRemovaleditsTest Plan
basic.md: Remove parens around integer literal(1)nested.md: Double-nested((1))produces two quickfix actionsmultiline.md: Multiline paren removal across linesneeded-paren.md: Negative -(1 + 2)does NOT offer actionRelated