Skip to content

nixd/Completion: fix isIncomplete flag handling #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Stoneman wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −2
Open

nixd/Completion: fix isIncomplete flag handling #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86c2238
nixd/Completion: fix isIncomplete flag handling
Mr-Stoneman Feb 9, 2026
e56aea4
Merge branch 'nix-community:main' into isIncomplete_Patch
Mr-Stoneman Mar 22, 2026
13f811c
Merge branch 'main' into isIncomplete_Patch
Mr-Stoneman Apr 11, 2026
f1910e3
Merge branch 'nix-community:main' into isIncomplete_Patch
Mr-Stoneman May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nixd/lib/Controller/Completion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ struct ExceedSizeError : std::exception {
};

void addItem(std::vector<CompletionItem> &Items, CompletionItem Item) {
Items.emplace_back(std::move(Item));
if (Items.size() >= MaxCompletionSize) {
throw ExceedSizeError();
}
Items.emplace_back(std::move(Item));
}

bool hasConcreteChild(const Node &N) {
Expand Down
2 changes: 1 addition & 1 deletion nixd/tools/nixd/test/completion/options-incomplete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
CHECK: "id": 1,
CHECK-NEXT: "jsonrpc": "2.0",
CHECK-NEXT: "result": {
CHECK-NEXT: "isIncomplete": false,
CHECK-NEXT: "isIncomplete": true,
```


Expand Down
Loading